Skip to content

boards: xtensa: esp32s2_franzininho: add support to the ESP32 S2 Franzininho educational development board. #50121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2022
Merged

boards: xtensa: esp32s2_franzininho: add support to the ESP32 S2 Franzininho educational development board. #50121

merged 1 commit into from
Oct 2, 2022

Conversation

@uLipe
Copy link
Member

@uLipe uLipe commented Sep 9, 2022

No description provided.

@zephyrbot zephyrbot added the platform: ESP32 Espressif ESP32 label Sep 9, 2022
@uLipe uLipe removed the request for review from dcpleung September 9, 2022 23:33
@uLipe
Copy link
Member Author

uLipe commented Sep 9, 2022

also @FBSeletronica, @joaodullius, PTAL, you might be interested on that.

@uLipe uLipe force-pushed the feature/esp32_franzininho branch 7 times, most recently from d2320b2 to 84f4fc8 Compare September 10, 2022 13:53
sylvioalves
sylvioalves reviewed Sep 12, 2022
View reviewed changes
sylvioalves
sylvioalves reviewed Sep 12, 2022
View reviewed changes
@uLipe uLipe force-pushed the feature/esp32_franzininho branch from ff5d7d8 to 7469e48 Compare September 13, 2022 03:39
@uLipe uLipe requested a review from sylvioalves September 13, 2022 03:39
sylvioalves
sylvioalves previously approved these changes Sep 19, 2022
View reviewed changes
LucasTambor
LucasTambor previously approved these changes Sep 19, 2022
View reviewed changes
@uLipe
Copy link
Member Author

uLipe commented Sep 19, 2022

@cfriedt, @fabiobaltieri any chance of this gets merged in this release, we are organizing an Zephyr session based on this educational board.

@fabiobaltieri
Copy link
Member

fabiobaltieri commented Sep 19, 2022

@cfriedt, @fabiobaltieri any chance of this gets merged in this release, we are organizing an Zephyr session based on this educational board.

We are in stabilization phase so we'd have to ask TSC approval, will you show up at the TSC meeting if I flag the PR for discussion?

Two things beside that:

  • can the second commit is just modifying/removing stuff added in the first one right? Can you squash the two? No sense keeping both in the history
  • can you reduce the board image resolution? We are trying to keep the repository size under control and the photo is very detailed

boards: xtensa: esp32s2_franzininho: add support
9317b95 
to the ESP32 S2 Franzininho educational development
board.

Signed-off-by: Felipe Neves <[email protected]>

boards: xtensa: esp32s2_franzininho: remove docs

section for debugging since this board does not have
any on board debug or connection for that.

Signed-off-by: Felipe Neves <[email protected]>
@uLipe uLipe dismissed stale reviews from LucasTambor and sylvioalves via 9317b95 September 19, 2022 19:04
@uLipe uLipe force-pushed the feature/esp32_franzininho branch from 7469e48 to 9317b95 Compare September 19, 2022 19:04
@uLipe
Copy link
Member Author

uLipe commented Sep 19, 2022

@fabiobaltieri thank you for your response, please flag this PR and I will be there to ask for TSC consideration.

I also applied your suggestions.

Thank you.

@uLipe uLipe requested a review from sylvioalves September 19, 2022 19:05
@uLipe uLipe requested a review from LucasTambor September 19, 2022 19:05
@fabiobaltieri fabiobaltieri added the TSC Topics that need TSC discussion label Sep 19, 2022
@fabiobaltieri fabiobaltieri added this to the v3.3.0 milestone Sep 21, 2022
@fabiobaltieri fabiobaltieri removed the TSC Topics that need TSC discussion label Sep 21, 2022
@fabiobaltieri
Copy link
Member

fabiobaltieri commented Sep 21, 2022

TSC decided to hold this for after the release. Updated the milestone tag accordingly.

@uLipe
Copy link
Member Author

uLipe commented Oct 2, 2022

Hi folks, it seems now clear to merge, no?

Thanks :)

@nashif nashif merged commit f0a85f6 into zephyrproject-rtos:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfriedt cfriedt cfriedt approved these changes

@sylvioalves sylvioalves sylvioalves approved these changes

@LucasTambor LucasTambor LucasTambor approved these changes

@nashif nashif Awaiting requested review from nashif

+1 more reviewer

@glaubermaroto glaubermaroto glaubermaroto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sylvioalves sylvioalves

Labels

platform: ESP32 Espressif ESP32

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

8 participants

@uLipe @fabiobaltieri @cfriedt @sylvioalves @LucasTambor @glaubermaroto @nashif @zephyrbot